Image Message Orientation Bug Fix #177
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Cause: due to EXIF orientation not well supported in picasso - Refactor matrixFromRotation in ImageUtils - Support "orientation" key value in ImageLoader - Pass orientation to ImageMessage in ConversationFragment.sendImageMessage - Transform image to desired orientation in ImagePreviewActivity Connects #161
carmenlau
requested changes
Mar 12, 2018
| @@ -391,12 +391,12 @@ open class ConversationFragment() : | |||
| /** | |||
| * This function is for receiving new message and sending new message. | |||
| */ | |||
| private fun addMessageToBottom(message: ChatMessage, uri: Uri? = null) { | |||
| private fun addMessageToBottom(message: ChatMessage, uri: Uri? = null, orientation: Int? = null) { | |||
There was a problem hiding this comment.
Adding orientation in ConversationFragment and ConversationView message functions look a bit strange as orientation is for image only, those functions should be generic for adding all message type. Besides that, this PR looks good for me.
- Moving message conversation logic and parameters from ConversationView to ConversationFragment Connects #177
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConversationFragment.sendImageMessage
Connects #161