Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image rotation bug fix #179

Merged
merged 2 commits into from Mar 16, 2018
Merged

Image rotation bug fix #179

merged 2 commits into from Mar 16, 2018

Conversation

howawong
Copy link
Contributor

Image Message Orientation Bug Fix

  • Cause: due to EXIF orientation not well supported in picasso
  • Refactor matrixFromRotation in ImageUtils
  • Support "orientation" key value in ImageLoader
  • Pass orientation to ImageMessage in
    ConversationFragment.sendImageMessage
  • Transform image to desired orientation in ImagePreviewActivity

Connects #161

howawong added 2 commits March 8, 2018 17:48
- Cause: due to EXIF orientation not well supported in picasso
- Refactor matrixFromRotation in ImageUtils
- Support "orientation" key value in ImageLoader
- Pass orientation to ImageMessage in
  ConversationFragment.sendImageMessage
- Transform image to desired orientation in ImagePreviewActivity

Connects #161
- Moving message conversation logic and parameters from ConversationView to ConversationFragment

Connects #161
@carmenlau carmenlau merged commit 2228809 into SkygearIO:master Mar 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants