Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Query.and #427

Merged
merged 3 commits into from
Jun 12, 2018
Merged

Implement Query.and #427

merged 3 commits into from
Jun 12, 2018

Conversation

Steven-Chan
Copy link

connect #376

Copy link
Contributor

@carmenlau carmenlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments only

* @param {Query} queries - Queries
*/

static or(...queries) {
static isSameRecordType(...queries) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to make this function private to avoid confusing the user?

@Steven-Chan
Copy link
Author

@carmenlau updated

@carmenlau carmenlau merged commit 78b7e6c into SkygearIO:master Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants