Fix/#496 oauth popup fail in ie11 #501
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the problem when npm install runs the prepublish stage, the dependencies used by skygear-core is not already installed. refs SkygearIO#284
Remove 4 from testing and use node 8 as deployment env
- Found `browserify` are called multiple times which is unexpected. Remove `watchify` from browserify, we are calling `browserify` in the watch tasks already. - We were using `config.src` which is empty in watch task, updated getting the src from packageConfigs instead.
This reverts commit f9606b7.
xml2js cannot run on react-native.
Only host of container endpoint was used in pubsub url, but the path should also be added.
achieve by redirecting to blank page first
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connects #496
magic...