Skip to content
This repository has been archived by the owner on Dec 22, 2023. It is now read-only.

make test is not working when WITH_DOCKER it set #157

Closed
2 tasks
rickmak opened this issue Oct 7, 2016 · 2 comments
Closed
2 tasks

make test is not working when WITH_DOCKER it set #157

rickmak opened this issue Oct 7, 2016 · 2 comments
Assignees

Comments

@rickmak
Copy link
Member

rickmak commented Oct 7, 2016

The provided DOCKER_RUN is not working since it don't boot postgresql and redis for testing

  • Skygear Server Date/Version: v0.17.0
  • Application Platform:
  • Is this a regression?
  • Attached logs, screenshots

Expected Results

Test passed

Actual Results

various dial tcp 127.0.0.1:6379: getsockopt: connection refused and Unable to begin transaction for schema migration: dial tcp [::1]:5432: getsockopt: connection refused indicate the test is fails.

Steps to reproduce

  1. WITH_DOCKER=1 make test
@cheungpat
Copy link
Contributor

Probably need to use docker-compose for the test to succeed, but docker-compose isn’t need for building the binary, so we either run docker-compose for all steps (which I don’t like, because that is unnecessary) or we provide WITH_DOCKER_COMPOSE=1 for that purpose.

I run test case in Docker using Docker Compose, but I run the command manually rather than using Makefile.

@cheungpat cheungpat self-assigned this Oct 7, 2016
@rickmak
Copy link
Member Author

rickmak commented Oct 7, 2016

I think it will be ok to using docker-compose to run test when WITH_DOCKER=1. Something like this?

ifeq (1,${WITH_DOCKER})
DOCKER_RUN := docker run xxxxx
DOCKER__COMPOSE_RUN := docker-compose xxxx
endif

cheungpat added a commit to cheungpat/skygear-server that referenced this issue Oct 7, 2016
cheungpat added a commit to cheungpat/skygear-server that referenced this issue Oct 7, 2016
cheungpat added a commit to cheungpat/skygear-server that referenced this issue Oct 7, 2016
rickmak added a commit that referenced this issue Oct 12, 2016
@rickmak rickmak closed this as completed Oct 17, 2016
@rickmak rickmak removed the In Review label Oct 17, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants