Skip to content
This repository has been archived by the owner on Dec 22, 2023. It is now read-only.

Check if an unsupported data type is queried, make sure the error message is understandable #231

Closed
royuen opened this issue Nov 14, 2016 · 2 comments
Closed

Check if an unsupported data type is queried, make sure the error message is understandable #231

royuen opened this issue Nov 14, 2016 · 2 comments
Assignees
@cheungpat

Comments

@royuen
Copy link
Contributor

royuen commented Nov 14, 2016 •
edited by rickmak
Loading

  • JS SDK
  • iOS SDK
  • Android SDK
@cheungpat
Copy link
Contributor

cheungpat commented Nov 17, 2016 •
edited
Loading

The following error is returned from skygear when the database contains a column with the type money:

{
  "error": {
    "name": "UnexpectedError",
    "code": 10000,
    "message": "received unknown data type = money for column = money"
  }
}

This is what the user will see:

screen shot 2016-11-17 at 2 23 17 pm

@royuen
Copy link
Contributor Author

royuen commented Nov 21, 2016

  • If the column is not supported, the record should still be returned, and that column will have a specific json notation to specify this is unsupported and thus there is no value.

cheungpat added a commit to cheungpat/skygear-server that referenced this issue Nov 22, 2016
@cheungpat
Better handling for unrecognized data type
4b280fa 
This is achieved by introducing a new skydb type called Unknown, which
will be passed to client when the server sees a column with an
unrecognized data type.

Previous behavior will result in skygear server throwing an error when
it sees a column with unrecognized data type.

refs SkygearIO#231
@cheungpat cheungpat mentioned this issue Nov 22, 2016
Closed
cheungpat added a commit to cheungpat/skygear-SDK-iOS that referenced this issue Nov 22, 2016
@cheungpat
Implement SKYUnknown
e873440 
refs SkygearIO/skygear-server#231
cheungpat added a commit to cheungpat/skygear-SDK-iOS that referenced this issue Nov 22, 2016
@cheungpat
Implement SKYUnknown
6e6f6f0 
refs SkygearIO/skygear-server#231
@cheungpat cheungpat mentioned this issue Nov 22, 2016
Closed
cheungpat added a commit to cheungpat/skygear-SDK-JS that referenced this issue Nov 22, 2016
@cheungpat
Implement server unknown type
4807375 
refs SkygearIO/skygear-server#231
@cheungpat cheungpat mentioned this issue Nov 22, 2016
Closed
cheungpat added a commit to cheungpat/skygear-SDK-iOS that referenced this issue Nov 22, 2016
@cheungpat
Implement SKYUnknownValue
3259e2c 
refs SkygearIO/skygear-server#231
cheungpat added a commit to cheungpat/skygear-SDK-Android that referenced this issue Nov 22, 2016
@cheungpat
Implement UnknownValue class
9f2bcfc 
refs SkygearIO/skygear-server#231
@cheungpat cheungpat mentioned this issue Nov 22, 2016
Closed
cheungpat added a commit to cheungpat/skygear-SDK-JS that referenced this issue Nov 22, 2016
@cheungpat
Implement server unknown type
362f738 
refs SkygearIO/skygear-server#231
cheungpat added a commit to cheungpat/skygear-server that referenced this issue Nov 22, 2016
@cheungpat
Better handling for unrecognized data type
5309989 
This is achieved by introducing a new skydb type called Unknown, which
will be passed to client when the server sees a column with an
unrecognized data type.

Previous behavior will result in skygear server throwing an error when
it sees a column with unrecognized data type.

refs SkygearIO#231
cheungpat added a commit to cheungpat/skygear-SDK-iOS that referenced this issue Nov 22, 2016
@cheungpat
Implement SKYUnknownValue
33216df 
refs SkygearIO/skygear-server#231
cheungpat added a commit to cheungpat/skygear-SDK-iOS that referenced this issue Nov 22, 2016
@cheungpat
Implement SKYUnknownValue
02addb0 
refs SkygearIO/skygear-server#231
cheungpat added a commit to cheungpat/skygear-SDK-iOS that referenced this issue Nov 22, 2016
@cheungpat
Implement SKYUnknownValue
327fc89 
refs SkygearIO/skygear-server#231
@rickmak rickmak mentioned this issue Nov 23, 2016
Closed
rickmak pushed a commit that referenced this issue Nov 23, 2016
@cheungpat @rickmak
Better handling for unrecognized data type
a6ddba0 
This is achieved by introducing a new skydb type called Unknown, which
will be passed to client when the server sees a column with an
unrecognized data type.

Previous behavior will result in skygear server throwing an error when
it sees a column with unrecognized data type.

refs #231
rickmak pushed a commit to SkygearIO/skygear-SDK-JS that referenced this issue Nov 23, 2016
@cheungpat @rickmak
Implement server unknown type
131517e 
refs SkygearIO/skygear-server#231
rickmak pushed a commit to SkygearIO/skygear-SDK-iOS that referenced this issue Nov 23, 2016
@cheungpat @rickmak
Implement SKYUnknownValue
4e932bb 
refs SkygearIO/skygear-server#231
rickmak pushed a commit to SkygearIO/skygear-SDK-Android that referenced this issue Nov 23, 2016
@cheungpat @rickmak
Implement UnknownValue class
bddd537 
refs SkygearIO/skygear-server#231
@rickmak rickmak mentioned this issue Nov 28, 2016
Closed
cheungpat added a commit to cheungpat/py-skygear that referenced this issue Nov 28, 2016
@cheungpat
Add support for UnknownValue type
5870ae3 
refs SkygearIO/skygear-server#231
@cheungpat cheungpat mentioned this issue Nov 28, 2016
Closed
cheungpat added a commit to cheungpat/py-skygear that referenced this issue Nov 28, 2016
@cheungpat
Add support for UnknownValue type
882fc40 
refs SkygearIO/skygear-server#231
refs SkygearIO#101
@rickmak rickmak mentioned this issue Nov 28, 2016
Closed
rickmak pushed a commit to SkygearIO/py-skygear that referenced this issue Nov 29, 2016
@cheungpat @rickmak
Add support for UnknownValue type
1729197 
refs SkygearIO/skygear-server#231
refs #101
@rickmak rickmak closed this as completed Dec 5, 2016
@rickmak rickmak removed the In Review label Dec 5, 2016
seventhmoon pushed a commit to astri-isns/skygear-SDK-Android that referenced this issue Feb 24, 2017
@cheungpat @seventhmoon
Implement UnknownValue class
a7a1559 
refs SkygearIO/skygear-server#231
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cheungpat cheungpat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rickmak @cheungpat @royuen