Skip to content
This repository has been archived by the owner on Dec 22, 2023. It is now read-only.

ACL setting is ignored when no user is logged in #59

Closed
cheungpat opened this issue Jun 28, 2016 · 0 comments
Closed

ACL setting is ignored when no user is logged in #59

cheungpat opened this issue Jun 28, 2016 · 0 comments
Assignees
@cheungpat
Milestone
0.13

Comments

@cheungpat
Copy link
Contributor

cheungpat commented Jun 28, 2016 •
edited by royuen
Loading

No description provided.

cheungpat added a commit to cheungpat/skygear-server that referenced this issue Jun 28, 2016
@cheungpat
Fix ACL in query without user
823bf14 
When there is no user for the query, the ACL is ignored because
ReadableBy is empty. The builder should only ignore ACL if the
database is a private database.

ReadableBy is renamed as ViewAsUser to avoid the variable semantics
to be overloadded with whether to apply ACL. If ViewAsUser is nil,
only public records can be queried.

refs SkygearIO#59
@cheungpat cheungpat mentioned this issue Jun 28, 2016
Merged
@rickmak rickmak closed this as completed Jun 29, 2016
@rickmak rickmak removed the In Review label Jun 29, 2016
@royuen royuen added this to the 0.13 milestone Jun 29, 2016
@chpapa chpapa mentioned this issue Apr 18, 2017
Closed
11 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cheungpat cheungpat

Labels
None yet
Projects
None yet
Milestone
0.13
Development

No branches or pull requests
3 participants
@rickmak @cheungpat @royuen