This repository has been archived by the owner on Dec 22, 2023. It is now read-only.
next: schema create handler #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmenlau
force-pushed
the
next-schema-create
branch
from
9b18150 to
5047e06
Compare
carmenlau
changed the title
|
I got |
I have no problem wo 🤔 |
|
@carmenlau I can repeat the error la. Probably we tested the api with a postgres database which has been used for another skygear v1 app. The function mentioned in the error message is |
…ous query cursor is not yet closed. Problem only happen when the queries are run in the same transaction, we don’t have db transaction in v1 schema create handler. So only apply this fix to next. Related issue: lib/pq#635
This is for record subscription in v1 which is no longer support in next
carmenlau
force-pushed
the
next-schema-create
branch
from
fd49def to
e9d501b
Compare
|
Removed the trigger creation when creating schema. Thanks! @rickmak @Steven-Chan |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connect #731
Commit 5047e06 is fixing problem that occur after adding transaction to schema create handler, we didn't have this problem in v1 as we didn't have transaction in schema create handler.
The problem happens if we make query before the previous query cursor close, updated
GetRecordSchemasto avoid this.related issue: lib/pq#635