Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't request a breaking version of postgres #7

Merged
merged 1 commit into from
Mar 15, 2020

Conversation

jyn514
Copy link
Contributor

@jyn514 jyn514 commented Jan 14, 2020

Before, it would try to compile with postgres 0.17 and break with errors like this:

error[E0412]: cannot find type `GenericConnection` in crate `postgres`
  --> src/lib.rs:28:31
   |
28 |     connection: &'a postgres::GenericConnection,
   |                               ^^^^^^^^^^^^^^^^^ not found in `postgres`

error[E0412]: cannot find type `GenericConnection` in crate `postgres`
  --> src/lib.rs:34:42
   |
34 |     pub fn new(connection: &'a postgres::GenericConnection) -> PostgresAdapter<'a> {
   |                                          ^^^^^^^^^^^^^^^^^ not found in `postgres`

error[E0412]: cannot find type `GenericConnection` in crate `postgres`
  --> src/lib.rs:40:35
   |
40 |         connection: &'a postgres::GenericConnection,
   |                                   ^^^^^^^^^^^^^^^^^ not found in `postgres`

error[E0603]: module `transaction` is private
 --> src/lib.rs:5:15
  |
5 | use postgres::transaction::Transaction;
  |               ^^^^^^^^^^^

Now, it compiles using 0.15 instead.

@palfrey
Copy link

palfrey commented Mar 14, 2020

This one just broke me as well. Any thoughts on what we need to get this merged?

@jyn514
Copy link
Contributor Author

jyn514 commented Mar 14, 2020

I don't think this crate is maintained, I'm probably going to end up rewriting the code for this in my own project.

@SkylerLipthay
Copy link
Owner

Sorry, I was inactive in January so this slipped by me. I haven't kept up with rust-postgres lately but I'm guessing the right action is not to restrict this crate to be stuck to an old version of rust-postgres. I think the best course of action is to change GenericConnection to GenericClient. I'll look into this in the next few hours.

@SkylerLipthay SkylerLipthay merged commit 556a12a into SkylerLipthay:master Mar 15, 2020
@SkylerLipthay
Copy link
Owner

Published 0.2.4 with this fix, which is compatible with postgres 0.15.

Also published 0.3.0, which is a majorly breaking change that makes this crate compatible with postgres 0.17.

Thank you and sorry for the delay!

@jyn514
Copy link
Contributor Author

jyn514 commented Mar 15, 2020

Thank you for your work on this crate!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants