Fil/sky 1060 wait for consensus sync before full setup

[firyx]

PULL REQUEST

Overview

Current playbooks wait in the following order:

• wait for Sia finished full setup
• wait for Sia consensus sync

This PR swaps order of waits so that portal operator is more accurately informed what happened when the wait fails.

Example for Visual Changes

Checklist

• All git commits are signed. (REQUIRED)
• All new methods or updated methods have clear docstrings.
• Testing added or updated for new methods.
• Verified if any changes impact the WebPortal Health Checks.
• Appropriate documentation updated.
• Changelog file created.

Issues Closed

[linear]

SKY-1060 Wait for consensus sync before wait for sia full setup

In the playbook there is a wait for "Wait until Sia finished full setup".

We should check that consensus is synced before the above check.

[MSevey]

skyd will complete a full set up on a fresh server before the consensus is sync. So this change is an anti-pattern.

What was the reason behind this change?

[firyx]

[firyx]

skyd will complete a full set up on a fresh server before the consensus is sync. So this change is an anti-pattern.

What was the reason behind this change?

I'm observing it otherwise:

• sia full setup doesn't finish until consensus is synced

[MSevey]

I'm observing it otherwise:

Is this on repeated runs of the setup playbook?

if so then we can figure out what is causing it to not finish the setup.

a syncing consensus on its own is not the blocking action. So we shouldn't switch these. We should figure out which action is blocking the setup due to the consensus syncing and see if that needs to be blocking.

[MSevey]

Pending longer discussion on root issue.