Skip to content
This repository has been archived by the owner on Jan 24, 2023. It is now read-only.

Mysky autologin remove email #254

Merged
merged 21 commits into from
Mar 9, 2022
Merged

Mysky autologin remove email #254

merged 21 commits into from
Mar 9, 2022

Conversation

mrcnski
Copy link
Contributor

@mrcnski mrcnski commented Feb 18, 2022

PULL REQUEST

Overview

As requested by the community, we want to stop using emails in order to derive the portal-specific seeds in MySky.

Closes #253

@mrcnski mrcnski marked this pull request as ready for review March 4, 2022 20:44
@mrcnski mrcnski requested review from ro-tex, kwypchlo and peterjan March 4, 2022 20:44
peterjan
peterjan previously approved these changes Mar 8, 2022
Copy link

@peterjan peterjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'm not fully up to speed with these PRs though but code-wise it looks perfect.

ro-tex
ro-tex previously approved these changes Mar 8, 2022
Copy link
Contributor

@ro-tex ro-tex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's merge and F/U.

@mrcnski mrcnski dismissed stale reviews from ro-tex and peterjan via 49a857e March 8, 2022 17:04
@mrcnski
Copy link
Contributor Author

mrcnski commented Mar 8, 2022

Captured followup issues in #274. Will address in a separate PR.

@mrcnski mrcnski mentioned this pull request Mar 8, 2022
@ro-tex ro-tex self-requested a review March 9, 2022 12:48
@mrcnski mrcnski merged commit dae3d6d into main Mar 9, 2022
@mrcnski mrcnski deleted the mysky-autologin-remove-email branch March 9, 2022 15:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove emails from MySky
3 participants