[MIRROR] Compresses vox audio files, adds a few more lines #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkyratBot
pushed a commit
that referenced
this pull request
Apr 28, 2022
* theft * I like punching my own team * Simplemobs have a stamina of 0, so ups required stamina to 10 * adds ishuman(), i can banish this if needed * Adds heldgloves & boxing glove subtype for them * oops * oops 2 * oops 3 * spriteadd #1, steals tg punching bag which should be okay to do * corporate issues fix * review compliance, 1line changes * touching up remove_gloves, not sure if I need to add QDEL_NULL to destroy() as well? * final review compliance: adds rightglove/rightglove_path as suggested in review (I think), adds NODROP toggle on create_gloves * adds clear-up QDEL_NULL on parent glove destroy * i accidentally added a fucking-around map, removes it * autodoc + nodrop compliance * disable/enable bitfield * fix: both hands receive gloves again, OR only checks until it finds a true condition * adds KO * OOPS * actually adds sprites for different coloured boxing gloves * early returns * Apply suggestions from code review Co-authored-by: BraveMole <bsouchu@ gmail.com> * Update code/modules/clothing/gloves/miscellaneous.dm Co-authored-by: TiviPlus <57223640+TiviPlus@ users.noreply.github.com> Co-authored-by: BraveMole <bsouchu@ gmail.com> Co-authored-by: TiviPlus <57223640+TiviPlus@ users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: tgstation/TerraGov-Marine-Corps#9637
About The Pull Request
Re-encodes and compresses the vox audio with variable bitrate, saving a fair amount of space for no readily apparent loss of audio quality. TG already does this with their vox, and the original HL1 announcer had same process done on it when CM accepted it.
Due to the size reduction I was also able to add 150+ new vox lines, and the end size is still smaller than it was before.
Why It's Good For The Game
The smaller the vox folder is the less bandwidth players need when we update, 6mb is the standard, but the size of our current vox folder has ballooned to 7mb due to additional TGMC specific words. This PR takes the size back to 6mb, where it belongs.
Changelog
🆑
soundadd: Vox sounds now take less space.
soundadd: Added more vox lines.
/:cl: