Chip component update #1326
Merged
Chip component update #1326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backpack/Chip/Classes/BPKChip.swift
Outdated
Comment on lines
68
to
70
| if isSelected { | ||
| accessibilityTraits.insert(.selected) | ||
| } |
There was a problem hiding this comment.
uicontrol should give this to us for free.
Backpack/Chip/Classes/BPKChip.swift
Outdated
Comment on lines
86
to
88
| if !isEnabled { | ||
| accessibilityTraits.insert(.notEnabled) | ||
| } |
There was a problem hiding this comment.
uicontrol should give this to us for free.
Comment on lines
21
to
23
| let off: Colors | ||
| // swiftlint:disable:next identifier_name | ||
| let on: Colors |
There was a problem hiding this comment.
could we use 'normal' and 'selected' as options?
| } | ||
| @objc | ||
| public enum BPKChipType: UInt { | ||
| case option, select, dismiss |
There was a problem hiding this comment.
We also need a version to support the chevron down
Comment on lines
+189
to
+191
| containerStackView.trailingAnchor.constraint(equalTo: trailingAnchor, constant: -chipHorizontalSpacing), | ||
| containerStackView.topAnchor.constraint(equalTo: topAnchor, constant: chipVerticalSpacing), | ||
| bottomAnchor.constraint(equalTo: containerStackView.bottomAnchor, constant: chipVerticalSpacing) | ||
| containerStackView.bottomAnchor.constraint(equalTo: bottomAnchor, constant: -chipVerticalSpacing) |
There was a problem hiding this comment.
Can we flip these constraints? So we don't have to use the negative value?
This is already done throughout the codebase
bottomAnchor.constraint(equalTo: containerStackView.bottomAnchor, constant: chipVerticalSpacing)
# Conflicts: # UNRELEASED.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the chip to reflect the design on Figma
https://gojira.skyscanner.net/browse/KOA-5149
Remember to include the following changes:
UNRELEASED.mdREADME.mdBackpack.hheader fileIf you are curious about how we review, please read through the code review guidelines