Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BPKBottomSheet #1358

Merged
merged 4 commits into from
Jun 30, 2022
Merged

Fix BPKBottomSheet #1358

merged 4 commits into from
Jun 30, 2022

Conversation

gert-janvercauteren
Copy link
Contributor

BPKBottomSheet:

  • Fix delegate method
  • Add option to change position without using animation

Remember to include the following changes:

If you are curious about how we review, please read through the code review guidelines

@gert-janvercauteren gert-janvercauteren self-assigned this Jun 30, 2022
@gert-janvercauteren gert-janvercauteren marked this pull request as ready for review June 30, 2022 05:24
@gert-janvercauteren gert-janvercauteren added the patch Patch production bug label Jun 30, 2022
@gert-janvercauteren gert-janvercauteren changed the title Fix bottomsheet Fix BPKBottomSheet Jun 30, 2022
@gert-janvercauteren gert-janvercauteren merged commit 1cd77bd into main Jun 30, 2022
@gert-janvercauteren gert-janvercauteren deleted the NOJIRA_fix_bottomsheet branch June 30, 2022 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Patch production bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants