[Lumen] LMN-1740: move geometry reader inside the component #2082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .padding([.leading, .top], .base) | ||
|
|
||
| ZStack(alignment: .bottom) { | ||
| GeometryReader { proxy in |
There was a problem hiding this comment.
The only change we made here is move the GeometryReader from line 47 to 55.
After investigation, found that GeometryReader will return zero width during initialization (there's no such behavior in older iOS, we always get width = 375 during initialization).
So here we try to move the GeometryReader inside the ZStack, in order to defer the execution of GeometryReader to get the correct width.
| Before | After |
|---|---|
 |
 |
Place to log:
There was a problem hiding this comment.
Interesting investigation!!
hchen-skyscanner
changed the title
frugoman
approved these changes
Oct 17, 2024
frugoman
deleted the
lumen/LMN-1740-Review-gallery-unable-to-show-image-in-iOS-18
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, we found that the review gallery failed to show image in iOS 18 devices, here we try to resolve it
Remember to include the following changes:
README.mdBackpack.hheader fileIf you are curious about how we review, please read through the code review guidelines