Fix: BPKChip goes beyond its parent when the text is too long #2090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iHandle
changed the title
iHandle
commented
Oct 25, 2024
| @@ -92,8 +92,10 @@ public struct BPKFlowStackView<Data: Collection, Content: View>: View where Data | |||
| let doesNotFitInCurrentRow = elementSize.width + spacing.width > remainingWidth | |||
|
|
|||
| if doesNotFitInCurrentRow { // new row | |||
| remainingWidth = availableWidth | |||
| currentRow += 1 | |||
| if rows.indices.contains(currentRow) { | |||
There was a problem hiding this comment.
If this element is the only element in the current row, we do not need to +1 to currentRow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
.lineLimit(1)instead of.fixedSize(horizontal: true, vertical: false)inChipButtonStyleso thatBPKChipwill not go beyond its parent due to too long text.BPKFlowStackViewwhen computing RowsPreview
Remember to include the following changes:
README.mdBackpack.hheader fileIf you are curious about how we review, please read through the code review guidelines