This repository has been archived by the owner on Dec 2, 2024. It is now read-only.
[BPK-3800] Upgrade most Storybook dependencies #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaundon
force-pushed
the
BPK-3800-storybook-upgrade
branch
from
77a58e3 to
9d0c01d
Compare
shaundon
commented
Apr 8, 2020
| // see: https://github.com/facebook/react-native/issues/18868#issuecomment-382671739 | ||
| YellowBox.ignoreWarnings(['Warning: isMounted(...) is deprecated']); | ||
| }; | ||
|
|
There was a problem hiding this comment.
I checked and this doesn't seem to be an issue anymore, so I removed it.
| const StorybookUI = getStorybookUI({ onDeviceUI: false }); | ||
| const StorybookUI = getStorybookUI({ | ||
| onDeviceUI: false, | ||
| asyncStorage: null, |
There was a problem hiding this comment.
I tried to get it working but it caused a world of hurt, and for such a small feature I thought it's not worth the hassle. We can revisit this in the future if necessary.
olliecurtis
approved these changes
Apr 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue is preventing us from upgrading
react-native-serverbut I was able to upgrade the rest. I'm now watching that issue so can try upgrading once it's resolved.