forked from facebook/create-react-app
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backpackify #39
Merged
Merged
Backpackify #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewdavidson
force-pushed
the
BPK-1801-brs-cra-2
branch
11 times, most recently
from
January 2, 2019 14:59
6ed32b1
to
a792e31
Compare
matthewdavidson
commented
Jan 2, 2019
matthewdavidson
commented
Jan 2, 2019
matthewdavidson
commented
Jan 2, 2019
matthewdavidson
force-pushed
the
BPK-1801-brs-cra-2
branch
5 times, most recently
from
January 3, 2019 09:46
263cea0
to
86bf1a9
Compare
Currently, the build is failing due to the following:
This is the exact same failure that is happening on upstream/master: https://travis-ci.org/facebook/create-react-app/builds/474283066. Related issue: facebook#6099 |
matthewdavidson
force-pushed
the
BPK-1801-brs-cra-2
branch
6 times, most recently
from
January 7, 2019 09:47
f4e5341
to
8ec3b70
Compare
matthewdavidson
force-pushed
the
BPK-1801-brs-cra-2
branch
3 times, most recently
from
January 7, 2019 14:04
901c4cf
to
101eee2
Compare
matthewdavidson
force-pushed
the
BPK-1801-brs-cra-2
branch
3 times, most recently
from
January 9, 2019 12:16
cc0386e
to
0158342
Compare
matthewdavidson
force-pushed
the
BPK-1801-brs-cra-2
branch
from
January 9, 2019 16:23
380beb1
to
7c8e082
Compare
shaundon
approved these changes
Jan 9, 2019
|
||
Create React App works on macOS, Windows, and Linux.<br> | ||
If something doesn’t work, please [file an issue](https://github.com/facebook/create-react-app/issues/new). | ||
In order to benefit from the ongoing open source development of create-react-app, this fork is kept up-to-date with the upstream repo. To aid this, we have preserved the existing repo structure, including all of the source code for the other packages that live alongside [`react-scripts`](https://github.com/facebook/create-react-app/tree/master/packages/react-scripts). **We do not modify any source code outside of [`react-scripts`](https://github.com/facebook/create-react-app/tree/master/packages/react-scripts).** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
In order to benefit from the ongoing open source development of create-react-app, this fork is kept up-to-date with the upstream repo. To aid this, we have preserved the existing repo structure, including all of the source code for the other packages that live alongside [`react-scripts`](https://github.com/facebook/create-react-app/tree/master/packages/react-scripts). **We do not modify any source code outside of [`react-scripts`](https://github.com/facebook/create-react-app/tree/master/packages/react-scripts).** | |
In order to benefit from the ongoing open-source development of create-react-app, this fork is kept up-to-date with the upstream repo. To aid this, we have preserved the existing repo structure, including all of the source code for the other packages that live alongside [`react-scripts`](https://github.com/facebook/create-react-app/tree/master/packages/react-scripts). **We do not modify any source code outside of [`react-scripts`](https://github.com/facebook/create-react-app/tree/master/packages/react-scripts).** |
Co-Authored-By: matthewdavidson <matthewdavidson@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades backpack-react-scripts from CRA 1.X to CRA 2.X. When reviewing, it's useful to compare it to the diff in #40 which contains all the changes made to CRA 1.X for
backpack-react-scripts
.Breaking changes:
See full list, the biggest being:
Vendor/common chunks enabled by defaultThis has been reversed so that they are now opt in via
enableAutomaticChunking
Theasset-manifest.json
is useless now- asset-manifest.json generated by CRA2 is not useful facebook/create-react-app#5513- Static keys for vendor bundle in asset-manifest.json facebook/create-react-app#5225Worked around this by setting
name
insplitChunks: { chunks: 'all', name: false, },
totrue
.Also added
css.html
andjs.html
fragments to output folder to encapsulate script order.Here is a list of things to test:
lodash
leaking to global scopejsonpFunction
sassFunctions
npm run lint
"backpack-react-scripts"
config:crossOriginLoading
babelIncludePrefixes
no longer requireddisablePolyfills
amdExcludes
externals
ssrExternals
cssModules