-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metrics logger to Config #231
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w0rmr1d3r
previously approved these changes
Jul 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look correct 😄
CHANGELOG.md
Outdated
Comment on lines
4
to
6
## [1.13.0] | ||
### Additions | ||
- `Config` includes a metrics logger and it is called to register when a filter is used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
## [1.13.0] | |
### Additions | |
- `Config` includes a metrics logger and it is called to register when a filter is used | |
## [1.13.0] | |
### Additions | |
- `Config` includes a metrics logger and it is called to register when a filter is used | |
- Default logging level from INFO to WARNING #230 |
ignaciobolonio
changed the title
Add metrics logger to Config
WIP Add metrics logger to Config
Jul 20, 2022
blaisejoshua1
previously approved these changes
May 28, 2023
jsoucheiron
previously approved these changes
May 29, 2023
ignaciobolonio
dismissed stale reviews from jsoucheiron, blaisejoshua1, and w0rmr1d3r
via
May 29, 2023 08:47
1d2c5ad
ignaciobolonio
changed the title
WIP Add metrics logger to Config
Add metrics logger to Config
May 29, 2023
w0rmr1d3r
approved these changes
May 30, 2023
jsoucheiron
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[1.14.0]
Additions
Config
includes a metrics logger and it is called to register when a filter is used