Migrate to pyproject.toml #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ignaciobolonio
approved these changes
Feb 19, 2024
w0rmr1d3r
approved these changes
Feb 21, 2024
Comment on lines
+131
to
+132
|
|
||
| [tool.setuptools_scm] |
There was a problem hiding this comment.
Question only: Is this needed if this section is empty?
There was a problem hiding this comment.
According to the documentation examples of the tool seems to be needed.
|
I'll let you merge it at your earliest convenience, as I don't have time to verify everything properly and there's a non-negligible chance that this will break |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading the project to use pyproject.toml
It upgrades several core components of the Makefile but has no real changes in the library besides dropping python 3.7 support (it's EOL anyway).
Changes: