Fix harcoded password rds rule #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoucheiron
previously approved these changes
Nov 25, 2019
| from cfripper.model.result import Result | ||
| from cfripper.model.utils import convert_json_or_yaml_to_dict |
There was a problem hiding this comment.
these imports have been imported in but don't seem to be used in the test file
| if master_user_password == Parameter.NO_ECHO_WITH_DEFAULT: | ||
| self.add_failure(type(self).__name__, self.REASON_DEFAULT.format(resource_type, logical_id)) | ||
| return True | ||
| elif master_user_password not in (Parameter.NO_ECHO_NO_DEFAULT, Parameter.NO_ECHO_WITH_VALUE,): |
There was a problem hiding this comment.
comma at end of line here
| @@ -19,29 +19,22 @@ | |||
|
|
|||
| class HardcodedRDSPasswordRule(Rule): | |||
|
|
|||
| REASON = "Default RDS {} password parameter or missing NoEcho for {}." | |||
| REASON_DEFAULT = "Default RDS {} password parameter (readable in plain-text) {}." | |||
There was a problem hiding this comment.
I would change to (readable in plain-text) for {}. :)
ocrawford555
approved these changes
Nov 25, 2019
jsoucheiron
approved these changes
Nov 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
HardcodedRDSPasswordRulenow reports two different messages when there is a missing echo or a readable password.Fixes
HardcodedRDSPasswordRulewas wrongly adding an error when a value is provided.