Skip to content

Commit

Permalink
🔄 synced local 'skyvern-frontend/src/' with remote 'skyvern-frontend/…
Browse files Browse the repository at this point in the history
…src/'

<!-- ELLIPSIS_HIDDEN -->

> [!IMPORTANT]
> Fixes action screenshot ordering and updates `Tabs` key in `WorkflowRunTimelineItemInfoSection.tsx`.
>
>   - **Behavior**:
>     - Fixes ordering of action screenshots in `ActionScreenshot.tsx` by reversing the index calculation.
>     - Changes `Tabs` key in `WorkflowRunTimelineItemInfoSection.tsx` to use `item.task_id` if available, ensuring unique keys.
>   - **Misc**:
>     - Adds a comment in `ActionScreenshot.tsx` explaining the reverse order of screenshots.
>
> <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 93820b19957779d13523a98e2c4e46137d770eee. It will automatically update as commits are pushed.</sup>

<!-- ELLIPSIS_HIDDEN -->
  • Loading branch information
wintonzheng committed Jan 2, 2025
1 parent 6286626 commit 02c14b3
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,8 @@ function ActionScreenshot({ stepId, index, taskStatus }: Props) {
(artifact) => artifact.artifact_type === ArtifactType.ActionScreenshot,
);

const screenshot = actionScreenshots?.[index];
// action screenshots are reverse ordered w.r.t action order
const screenshot = actionScreenshots?.[actionScreenshots.length - index - 1];

if (isLoading) {
return (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ function WorkflowRunTimelineItemInfoSection({ activeItem }: Props) {
) {
return (
<div className="rounded bg-slate-elevation1 p-4">
<Tabs key={item.block_type} defaultValue={defaultTab}>
<Tabs key={item.task_id ?? item.block_type} defaultValue={defaultTab}>
<TabsList>
{item.status === Status.Completed && (
<TabsTrigger value="extracted_information">
Expand Down

0 comments on commit 02c14b3

Please sign in to comment.