Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fallback to press arrowdown to trigger dropdown menu #1074

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

LawyZheng
Copy link
Collaborator

@LawyZheng LawyZheng commented Oct 28, 2024

Important

Adds fallback in handle_select_option_action to press 'ArrowDown' for input elements to trigger dropdown if no incremental elements are detected.

  • Behavior:
    • In handle_select_option_action in handler.py, added fallback to press 'ArrowDown' if no incremental elements are detected for input elements to trigger dropdown.
    • Waits 5 seconds after pressing 'ArrowDown' for options to load.
  • Logging:
    • Logs information when 'ArrowDown' is pressed due to no incremental elements detected.

This description was created by Ellipsis for 2708015. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 2708015 in 16 seconds

More details
  • Looked at 27 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern/webeye/actions/handler.py:843
  • Draft comment:
    The ArrowDown key is pressed twice to trigger the dropdown menu. The second attempt (lines 843-856) is redundant and should be removed.
  • Reason this comment was not posted:
    Comment was on unchanged code.

Workflow ID: wflow_E05YlSNhqYe5aQiv


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@LawyZheng LawyZheng merged commit 777876d into main Oct 28, 2024
2 checks passed
@LawyZheng LawyZheng deleted the lawy/fallback-custom-select-trigger branch October 28, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant