Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include download in action history #1078

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

wintonzheng
Copy link
Contributor

@wintonzheng wintonzheng commented Oct 28, 2024

Important

Adds download field to action history JSON output in agent.py.

  • Behavior:
    • Adds download field to action history JSON output in _get_action_results() in agent.py.

This description was created by Ellipsis for b6b3d3e. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to b6b3d3e in 10 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern/forge/agent.py:1222
  • Draft comment:
    Ensure that the 'download' field is correctly populated in the Action model to avoid potential issues when dumping the model.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR adds 'download' to the include set in the model_dump call, which is consistent with the intent to include download information in the action history. This change is straightforward and doesn't introduce any apparent issues.

Workflow ID: wflow_TDxpO1xaFpQKVyi1


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@wintonzheng wintonzheng merged commit e4f005b into main Oct 28, 2024
2 checks passed
@wintonzheng wintonzheng deleted the shu/include_download_in_action_history branch October 28, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants