Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update Dockerfile" #1082

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Revert "Update Dockerfile" #1082

merged 1 commit into from
Oct 29, 2024

Conversation

wintonzheng
Copy link
Contributor

@wintonzheng wintonzheng commented Oct 29, 2024

Reverts #1056


Important

Reverts Dockerfile to previous state, removing multi-stage build and simplifying dependency installation.

  • Revert Changes:
    • Reverts multi-stage build process in Dockerfile.
    • Removes base-stage and final-stage separation.
    • Simplifies dependency installation by removing separate Poetry installation and requirements export.
  • Dependency Management:
    • Directly installs requirements in a single stage.
    • Retains playwright installation and dependencies.
  • Entrypoint:
    • Changes ENTRYPOINT to CMD for entrypoint-skyvern.sh.

This description was created by Ellipsis for fe2939c. It will automatically update as commits are pushed.

@wintonzheng wintonzheng merged commit e4a834d into main Oct 29, 2024
2 checks passed
@wintonzheng wintonzheng deleted the revert-1056-patch-1 branch October 29, 2024 06:51
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to fe2939c in 8 seconds

More details
  • Looked at 61 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. Dockerfile:12
  • Draft comment:
    Consider combining the RUN commands on lines 12, 13, 14, and 15 into a single RUN command to reduce the number of layers in the Docker image. This can improve build performance and reduce image size.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The use of multiple RUN commands can be optimized to reduce the number of layers in the Docker image.

Workflow ID: wflow_9mcM5a8uEPFtddcM


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant