Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update prompt to fix terminate issue #1086

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Conversation

LawyZheng
Copy link
Collaborator

@LawyZheng LawyZheng commented Oct 29, 2024

Important

Update action_plan in extract-action.j2 to include "TERMINATE" action for process termination scenarios.

  • Behavior:
    • Updated action_plan in extract-action.j2 to include outputting "TERMINATE" action if the plan is to terminate the process.

This description was created by Ellipsis for ca03fb2. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to ca03fb2 in 9 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern/forge/prompts/skyvern/extract-action.j2:12
  • Draft comment:
    Remove comment syntax (//) to ensure valid JSON output.
  • Reason this comment was not posted:
    Comment was on unchanged code.

Workflow ID: wflow_P0DNgeZm2o7kIfeu


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@LawyZheng LawyZheng merged commit 54674c1 into main Oct 29, 2024
2 checks passed
@LawyZheng LawyZheng deleted the lawy/fix-termiante-issue branch October 29, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant