automatically parse file extension when downloading

[LawyZheng]

Important

Enhance download_file() in files.py to auto-detect file extensions from HTTP headers if missing in URL.

• Behavior:
  • download_file() in files.py now attempts to determine file extension from HTTP headers if not present in URL.
  • Logs a warning if no extension is retrieved and logs an exception if retrieval fails.
• Functions:
  • Adds get_file_extension_from_headers() to extract file extension from Content-Disposition or Content-Type headers.
• Imports:
  • Adds mimetypes, re, and CIMultiDictProxy imports in files.py.

^{This description was created by for 504b44f. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 504b44f in 33 seconds

More details

• Looked at 62 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 3 drafted comments based on config settings.

1. skyvern/forge/sdk/api/files.py:69

• Draft comment:
  Typo: 'retreived' should be 'retrieved'. This occurs in multiple places (lines 69 and 71).
• Reason this comment was not posted:
  Confidence changes required: 10%
  The code uses 'retreive' instead of 'retrieve' in multiple places, which is a typo.

2. skyvern/forge/sdk/api/files.py:70

• Draft comment:
  Catching a general exception is not a best practice. Consider catching specific exceptions that might occur when retrieving the file extension from headers.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The code uses a try-except block to catch a general exception, which is not a best practice.

3. skyvern/forge/sdk/api/files.py:71

• Draft comment:
  Typo: 'retreive' should be 'retrieve'. This occurs in multiple places (lines 69 and 71).
• Reason this comment was not posted:
  Confidence changes required: 10%
  The code uses 'retreive' instead of 'retrieve' in multiple places, which is a typo.

Workflow ID: wflow_fw6LEnS10DJIJRkY

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.