Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix workflow can't save browser console log #1102

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

LawyZheng
Copy link
Collaborator

@LawyZheng LawyZheng commented Oct 31, 2024

Important

Adds call to persist_browser_console_log() in persist_debug_artifacts() to save browser console logs.

  • Behavior:
    • Adds call to persist_browser_console_log() in persist_debug_artifacts() in service.py to save browser console logs during workflow execution.

This description was created by Ellipsis for ec64fe8. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to ec64fe8 in 34 seconds

More details
  • Looked at 12 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern/forge/sdk/workflow/service.py:884
  • Draft comment:
    The addition of persist_browser_console_log ensures that browser console logs are saved as part of the debug artifacts. This is a good addition for capturing more comprehensive debug information.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The change in the PR adds a call to persist_browser_console_log before other data persistence methods. This ensures that the browser console log is saved as part of the debug artifacts.

Workflow ID: wflow_lNE9f2Rh39FLmx6A


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@LawyZheng LawyZheng merged commit de19cef into main Oct 31, 2024
2 checks passed
@LawyZheng LawyZheng deleted the lawy/fix-workflow-browser-log-save branch October 31, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant