Raise screenshot error earlier when page is closed #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Raise `FailedToTakeScreenshot` in `take_screenshot()` if `page.is_closed()` in `page.py`. > > - **Behavior**: > - In `take_screenshot()` in `page.py`, raise `FailedToTakeScreenshot` if `page.is_closed()` before attempting to take a screenshot. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 2627a3801b74877c0a64d30a67383f4a7acc901b. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 095d430 in 6 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/webeye/utils/page.py:43
- Draft comment:
Consider including the page URL or identifier in the error message for better debugging context. - Reason this comment was not posted:
Confidence changes required:50%
The error message should be more descriptive to help with debugging.
Workflow ID: wflow_wdq1Dy7pSdvRUH7X
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 095d430 in 9 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/webeye/utils/page.py:43
- Draft comment:
Consider providing more context in the error message, such as the page URL or identifier, to aid in debugging. - Reason this comment was not posted:
Confidence changes required:50%
The error message should be more descriptive to help with debugging.
Workflow ID: wflow_KBhtDaSqR531UDyy
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 155c5ee in 9 seconds
More details
- Looked at
28lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. docs/integrations/workato.md:1
- Draft comment:
The PR description mentions changes inpage.pyto raise an error when a page is closed, but the diff only shows changes to this markdown file. Ensure the intended code changes are included in the PR. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_ttVQ1WzhYYgDvOEr
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
wintonzheng
deleted the
shu/raise_screenshot_error_early_when_page_is_closed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Raise
FailedToTakeScreenshotintake_screenshot()ifpage.is_closed()inpage.pyand add TOC toworkato.md.take_screenshot()inpage.py, raiseFailedToTakeScreenshotifpage.is_closed()before attempting to take a screenshot.workato.md.This description was created by
for 155c5ee. It will automatically update as commits are pushed.