Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add browser console log #1120

Merged
merged 1 commit into from
Nov 4, 2024
Merged

add browser console log #1120

merged 1 commit into from
Nov 4, 2024

Conversation

LawyZheng
Copy link
Collaborator

@LawyZheng LawyZheng commented Nov 4, 2024

Important

Add browser console log URL retrieval and inclusion in task response in agent_protocol.py and tasks.py.

  • Behavior:
    • get_task in agent_protocol.py now retrieves the latest browser console log artifact for a task and generates a shareable URL.
    • The URL is included in the task response as browser_console_log_url.
  • Models:
    • TaskResponse in tasks.py updated to include browser_console_log_url field.
    • to_task_response method in Task class updated to handle browser_console_log_url.

This description was created by Ellipsis for a63690a. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to a63690a in 32 seconds

More details
  • Looked at 57 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern/forge/sdk/routes/agent_protocol.py:324
  • Draft comment:
    The addition of browser_console_log_url is consistent across the get_task function and the TaskResponse model. Ensure that this field is handled correctly in all parts of the application that use TaskResponse.
  • Reason this comment was not posted:
    Confidence changes required: 20%
    The PR adds a new field browser_console_log_url to the TaskResponse model. This field is correctly added to the to_task_response method in Task class and the TaskResponse class itself. The changes are consistent and correctly implemented.

Workflow ID: wflow_Sp012mzyzICV47ZO


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@LawyZheng LawyZheng merged commit 971e726 into main Nov 4, 2024
2 checks passed
@LawyZheng LawyZheng deleted the lawy/add-browser-console-log branch November 4, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant