Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Call LLM API Log #1132

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Remove Call LLM API Log #1132

merged 1 commit into from
Nov 5, 2024

Conversation

wintonzheng
Copy link
Contributor

@wintonzheng wintonzheng commented Nov 5, 2024

Important

Remove logging statements for LLM API call attempts and successes in llm_api_handler_with_router_and_fallback function in api_handler_factory.py.

  • Logging:
    • Remove LOG.info statements for LLM API call attempts and successes in llm_api_handler_with_router_and_fallback function in api_handler_factory.py.

This description was created by Ellipsis for ad384bc. It will automatically update as commits are pushed.

<!-- ELLIPSIS_HIDDEN -->

> [!IMPORTANT]
> Remove logging statements for LLM API call attempts and successes in `llm_api_handler_with_router_and_fallback` function.
>
>   - **Logging**:
>     - Remove `LOG.info` statements for LLM API call attempts and successes in `llm_api_handler_with_router_and_fallback` function in `api_handler_factory.py`.
>
> <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 125353923653afabad72b3e5086074df02df81a2. It will automatically update as commits are pushed.</sup>

<!-- ELLIPSIS_HIDDEN -->
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on ad384bc in 11 seconds

More details
  • Looked at 12 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern/forge/sdk/api/llm/api_handler_factory.py:107
  • Draft comment:
    The log statement for successful LLM API calls should be removed as per the PR description.
  • Reason this comment was not posted:
    Comment did not seem useful.

Workflow ID: wflow_EFuwqPMjhhtD1IOl


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to ad384bc in 11 seconds

More details
  • Looked at 12 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern/forge/sdk/api/llm/api_handler_factory.py:107
  • Draft comment:
    The LOG.info statement for successful LLM API calls should also be removed as per the PR description.
  • Reason this comment was not posted:
    Comment did not seem useful.

Workflow ID: wflow_jTCPoPogfPmgvJaf


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@suchintan suchintan merged commit 281feb6 into main Nov 5, 2024
2 checks passed
@suchintan suchintan deleted the suchintan.remove-log branch November 5, 2024 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants