Refactor status util function #1137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Refactor task finalization logic by removing `taskIsFinalized` from `utils.ts` and using `statusIsFinalized` in `TaskDetails.tsx`. > > - **Refactor**: > - Remove `taskIsFinalized` from `utils.ts`. > - Replace `taskIsFinalized` with `statusIsFinalized` in `TaskDetails.tsx`. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 1e93845935e86f8f955b2ad23b5b2b333f08cf93. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 3c9945e in 11 seconds
More details
- Looked at
49lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/tasks/detail/TaskDetails.tsx:34
- Draft comment:
EnsurestatusIsFinalizedis correctly imported from the intended module. Double-check the import path. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_kBb7tDwZUN62SPsr
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
❌ Changes requested. Incremental review on 3c9945e in 43 seconds
More details
- Looked at
47lines of code in2files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_iA2lyF9szSn7EcYm
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -147,7 +147,7 @@ function TaskDetails() { | |||
| const taskIsRunningOrQueued = | |||
| task?.status === Status.Running || task?.status === Status.Queued; | |||
|
|
|||
| const taskHasTerminalState = task && taskIsFinalized(task); | |||
| const taskHasTerminalState = task && statusIsFinalized(task); | |||
There was a problem hiding this comment.
statusIsFinalized should be called with task.status instead of task.
Suggested change
| const taskHasTerminalState = task && statusIsFinalized(task); | |
| const taskHasTerminalState = task && statusIsFinalized(task.status); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Refactor task finalization logic by removing
taskIsFinalizedfromutils.tsand usingstatusIsFinalizedinTaskDetails.tsx.taskIsFinalizedfromutils.ts.taskIsFinalizedwithstatusIsFinalizedinTaskDetails.tsx.This description was created by
for 3c9945e. It will automatically update as commits are pushed.