fix unclosed browser when navigation error

[LawyZheng]

Important

Fixes unclosed browser issue by reordering operations in get_or_create_for_task and get_or_create_for_workflow_run in browser_manager.py.

• Behavior:
  • Fixes unclosed browser issue by reordering operations in get_or_create_for_task and get_or_create_for_workflow_run in browser_manager.py.
  • Assigns browser_state to self.pages before calling get_or_create_page() to ensure proper cleanup in case of errors.
• Misc:
  • No changes to logging or error handling logic.

^{This description was created by for 4f31c39. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 4f31c39 in 15 seconds

More details

• Looked at 41 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. skyvern/webeye/browser_manager.py:78

• Draft comment:
  The change in order of setting self.pages before get_or_create_page ensures that the browser state is stored even if an error occurs during page creation. This helps in preventing resource leaks.
• Reason this comment was not posted:
  Confidence changes required: 0%
  The PR changes the order of setting self.pages in get_or_create_for_task and get_or_create_for_workflow_run methods. This change ensures that the browser state is stored before any potential errors occur during page creation. This is a good practice to prevent resource leaks in case of errors.

Workflow ID: wflow_nsU0qnTM42kYX4Op

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.