download with file extension

[LawyZheng]

Important

Adds automatic file extension handling for downloads in browser_factory.py using set_download_file_listener() and introduces BROWSER_DOWNLOAD_TIMEOUT.

• Behavior:
  • Adds set_download_file_listener() in browser_factory.py to automatically add file extensions to downloads if missing.
  • Uses download.suggested_filename and download.url to determine file extension.
  • Cancels download if it exceeds BROWSER_DOWNLOAD_TIMEOUT.
• Constants:
  • Adds BROWSER_DOWNLOAD_TIMEOUT in constants.py set to 600 seconds.
• Logging:
  • Logs actions and errors related to file extension handling in set_download_file_listener().

^{This description was created by for 5b63c07. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 5b63c07 in 55 seconds

More details

• Looked at 111 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 2 drafted comments based on config settings.

1. skyvern/webeye/browser_factory.py:78

• Draft comment:
  asyncio.timeout is not a valid function. Use asyncio.wait_for instead to set a timeout for an async operation.
• Reason this comment was not posted:
  Marked as duplicate.

2. skyvern/webeye/browser_factory.py:206

• Draft comment:
  asyncio.timeout is not a valid function. Use asyncio.wait_for instead to set a timeout for an async operation. (Also applicable on line 509 and 521)
• Reason this comment was not posted:
  Comment was on unchanged code.

Workflow ID: wflow_qaQHdMpebuPT7xtH

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.