Fix a bug with loop block children order on save

[wintonzheng]

Important

Fixes loop block children order bug on save by using edges in getWorkflowBlocks in workflowEditorUtils.ts.

• Behavior:
  • Fixes bug in handleSave() in FlowRenderer.tsx by passing edges to getWorkflowBlocks to ensure correct order of loop block children.
• Functions:
  • Adds getOrderedChildrenBlocks() in workflowEditorUtils.ts to determine the order of loop block children using edges.
  • Updates getWorkflowBlocksUtil() in workflowEditorUtils.ts to use getOrderedChildrenBlocks() for loop blocks.
• Misc:
  • Updates getWorkflowBlocks() in workflowEditorUtils.ts to accept edges parameter.

^{This description was created by for f773255. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to f773255 in 1 minute and 7 seconds

More details

• Looked at 103 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. skyvern-frontend/src/routes/workflows/editor/workflowEditorUtils.ts:663

• Draft comment:
  Consider adding a mechanism to detect cycles in the graph to prevent potential infinite loops when traversing nodes.
• Reason this comment was not posted:
  Decided after close inspection that this draft comment was likely wrong and/or not actionable:
  The comment is speculative as it suggests a potential issue without strong evidence of its existence. The current implementation appears to handle node traversal in a straightforward manner, reducing the likelihood of cycles. Without evidence of cycles being a problem, the comment may not be necessary.
  I might be underestimating the complexity of the graph structure and the potential for cycles. The function's logic could be more complex than it appears, and cycles might be a real concern.
  The function's logic seems straightforward, and without evidence of cycles being an issue, the comment remains speculative. The code does not show signs of handling complex graph structures that would inherently create cycles.
  The comment is speculative and not based on strong evidence of an issue. It should be removed as it does not point to a definite problem in the code.

Workflow ID: wflow_j4TmJsYT2xkMQHOk

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.