fix download file extension #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 844f8a9 in 1 minute and 34 seconds
More details
- Looked at
26lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/forge/agent.py:302
- Draft comment:
Ensure that the file extension is preserved when renaming files by appendingfile_extensiontorandom_file_name. This change is correct and necessary to maintain the integrity of the downloaded files. - Reason this comment was not posted:
Confidence changes required:0%
The PR fixes the issue of missing file extensions when renaming downloaded files. The change is correct and aligns with the intent to preserve file extensions.
Workflow ID: wflow_cszXcHNe2oGGMM9r
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -293,11 +294,12 @@ async def execute_step( | |||
| if len(list_files_after) > len(list_files_before): | |||
| files_to_rename = list(set(list_files_after) - set(list_files_before)) | |||
| for file in files_to_rename: | |||
| file_extension = Path(file).suffix | |||
There was a problem hiding this comment.
This code duplicates existing functionality for extracting file extensions using Path(filename).suffix in skyvern/forge/sdk/api/files.py. Consider reusing or extending the existing code to avoid duplication.
- file_extension extraction (files.py)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Fixes file renaming in
execute_step()inagent.pyto retain original file extensions for downloaded files.execute_step()inagent.pyto append the original file extension to the new file name.This description was created by
for 844f8a9. It will automatically update as commits are pushed.