Add proxy location to workflow run screen

[wintonzheng]

Important

Add proxy location selection to RunWorkflowForm with new ProxyLocation type and update related API types.

• Types:
  • Add ProxyLocation type in types.ts with options for various residential proxies and None.
  • Update proxy_location fields in CreateTaskRequest, WorkflowApiResponse, WorkflowRunApiResponse, and WorkflowRunStatusApiResponse to use ProxyLocation type.
• Form:
  • Add proxyLocation field to RunWorkflowForm in RunWorkflowForm.tsx with a select input for choosing proxy locations.
  • Default proxyLocation to Residential in form initial values.
  • Update getRunWorkflowRequestBody to include proxyLocation in the request body.
• Misc:
  • Refactor onSubmit and cURL generation to use getRunWorkflowRequestBody.

^{This description was created by for 9980bc5. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Incremental review on 9980bc5 in 17 seconds

More details

• Looked at 296 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. skyvern-frontend/src/routes/workflows/RunWorkflowForm.tsx:113

• Draft comment:
  Ensure that setting proxyLocation to ProxyLocation.Residential as the default value is the intended behavior.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The proxy_location field is being set to ProxyLocation.Residential by default in the form's initial values. This is a good practice to ensure a default value is selected, but it should be confirmed that this is the intended default behavior.

Workflow ID: wflow_qechdVmCBZq5OBKT

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 9980bc5 in 45 seconds

More details

• Looked at 296 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 3 drafted comments based on config settings.

1. skyvern-frontend/src/routes/workflows/RunWorkflowForm.tsx:113

• Draft comment:
  Ensure that setting proxyLocation to ProxyLocation.Residential as the default value is the intended behavior.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The proxy_location field is being set to ProxyLocation.Residential by default in the form's initial values. This is a good practice to ensure a default value is selected, but it should be confirmed that this is the intended default behavior.

2. skyvern-frontend/src/routes/workflows/RunWorkflowForm.tsx:157

• Draft comment:
  Good use of getRunWorkflowRequestBody to ensure consistent request body preparation.
• Reason this comment was not posted:
  Confidence changes required: 0%
  The onSubmit function in RunWorkflowForm is correctly using the getRunWorkflowRequestBody function to prepare the request body, ensuring consistency across different parts of the code.

3. skyvern-frontend/src/routes/workflows/RunWorkflowForm.tsx:93

• Draft comment:
  Consider explicitly checking for non-null values for webhookCallbackUrl to avoid issues with falsy values like an empty string.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The getRunWorkflowRequestBody function is well-structured, but the webhookCallbackUrl is being checked for truthiness before being added to the body. This could be improved by explicitly checking for non-null values to avoid potential issues with falsy values like an empty string.

Workflow ID: wflow_1AnktOU23AKObrhx

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.