update pre-commit

[wintonzheng]

Important

Update pre-commit versions and replace type() with isinstance() for type checking in handler.py.

• Pre-commit Configuration:
  • Update pre-commit-hooks to v5.0.0, ruff-pre-commit to v0.7.3, and mirrors-mypy to v1.13.0 in .pre-commit-config.yaml.
• Code Fixes:
  • Replace type() with isinstance() for type checking in handle_action() and fc_func() in handler.py.

^{This description was created by for 9cd8605. It will automatically update as commits are pushed.}

[ellipsis-dev]

❌ Changes requested. Reviewed everything up to 010ed96 in 1 minute and 0 seconds

More details

• Looked at 54 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. skyvern/webeye/actions/handler.py:1135

• Draft comment:
  The condition if isinstance(sibling_action_result, ActionSuccess): should be if not isinstance(sibling_action_result, ActionSuccess): to match the original logic of checking for non-successful actions.
• Reason this comment was not posted:
  Marked as duplicate.

Workflow ID: wflow_4rAAHGq4VXf0Y1ds

---

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

The condition if not results or isinstance(actions_result[-1], ActionSuccess): seems incorrect. It should be if not results or not isinstance(actions_result[-1], ActionSuccess): to match the original logic of checking for non-successful actions.

Suggested change

	if not results or isinstance(actions_result[-1], ActionSuccess):
	if not results or not isinstance(actions_result[-1], ActionSuccess):

[ellipsis-dev]

👍 Looks good to me! Incremental review on 9cd8605 in 18 seconds

More details

• Looked at 54 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. skyvern/webeye/actions/handler.py:251

• Draft comment:
  The use of isinstance() for type checking is a good practice. It is more reliable and readable than using type(). This change is correctly implemented here and in fc_func().
• Reason this comment was not posted:
  Confidence changes required: 0%
  The use of isinstance() is a good practice for type checking, as it is more reliable and readable than using type(). The changes made in the PR are correct and align with best practices.

Workflow ID: wflow_8NuzIITbYeZjcntf

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.