Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend auto completion to support google address #1174

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

LawyZheng
Copy link
Collaborator

@LawyZheng LawyZheng commented Nov 12, 2024

Important

Extend auto-completion to support Google address by updating isInteractable() in domUtils.js and is_auto_completion_input() in dom.py.

  • Behavior:
    • Extend isInteractable() in domUtils.js to recognize Google Maps auto-complete elements (div.pac-item within div.pac-container) as interactable.
    • Update is_auto_completion_input() in dom.py to return True for elements with class autocomplete-input.
  • Misc:
    • Modify isInteractable() in domUtils.js to use div[id*="dropdown-container"] instead of div[id^="dropdown-container"].

This description was created by Ellipsis for e6da81d. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to e6da81d in 47 seconds

More details
  • Looked at 54 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern/webeye/utils/dom.py:146
  • Draft comment:
    Ensure class_name is not None before checking for 'autocomplete-input'.
  • Reason this comment was not posted:
    Comment did not seem useful.

Workflow ID: wflow_SOJWK8lSbiGmaV0Z


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@LawyZheng LawyZheng merged commit 46d9dad into main Nov 12, 2024
2 checks passed
@LawyZheng LawyZheng deleted the lawy/extend-auto-complete-coverage branch November 12, 2024 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant