Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make task block title empty string by default; use task_block.label for the running task.title if task_block.title is empty #1181

Merged
merged 1 commit into from
Nov 13, 2024
Merged

make task block title empty string by default; use task_block.label for the running task.title if task_block.title is empty #1181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion skyvern/forge/agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ async def create_task_and_step_from_block(
task_url = validate_url(task_url)
task = await app.DATABASE.create_task(
url=task_url,
title=task_block.title,
title=task_block.title or task_block.label,
webhook_callback_url=None,
totp_verification_url=task_block.totp_verification_url,
totp_identifier=task_block.totp_identifier,
Expand Down
2 changes: 1 addition & 1 deletion skyvern/forge/sdk/workflow/models/block.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ class TaskBlock(Block):
block_type: Literal[BlockType.TASK] = BlockType.TASK

url: str | None = None
title: str = "Untitled Task"
title: str = ""
navigation_goal: str | None = None
data_extraction_goal: str | None = None
data_schema: dict[str, Any] | list | None = None
Expand Down
2 changes: 1 addition & 1 deletion skyvern/forge/sdk/workflow/models/yaml.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ class TaskBlockYAML(BlockYAML):
block_type: Literal[BlockType.TASK] = BlockType.TASK # type: ignore

url: str | None = None
title: str = "Untitled Task"
title: str = ""
navigation_goal: str | None = None
data_extraction_goal: str | None = None
data_schema: dict[str, Any] | list | None = None
Expand Down
Loading