Avoid overflow in running workflow sidebar #1183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Prevent overflow in `WorkflowRun.tsx` sidebar by adding `min-w-0` and `truncate` attributes. > > - **UI Improvements**: > - Add `min-w-0` to the sidebar `div` in `WorkflowRun.tsx` to prevent overflow. > - Add `truncate` and `title` attributes to `span` elements displaying `currentRunningTask.request.url` and `currentRunningTask.created_at` to handle text overflow. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for fe872ad10320a441be8396f976c534beff1b8c83. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on ef118a5 in 12 seconds
More details
- Looked at
37lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/WorkflowRun.tsx:381
- Draft comment:
Ensuretitleattribute is used consistently for all potentially truncated elements to provide full content on hover. - Reason this comment was not posted:
Confidence changes required:50%
The use ofmin-w-0andtruncateis appropriate for preventing overflow issues in the sidebar. However, thetitleattribute should be used consistently for all elements that might be truncated to provide a tooltip with the full content.
Workflow ID: wflow_EQG6o3iwGSzwKO1B
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to ef118a5 in 17 seconds
More details
- Looked at
37lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/WorkflowRun.tsx:381
- Draft comment:
Ensure thetitleattribute is used consistently for all truncated elements to provide full information on hover. This is done correctly here, but check other similar elements. - Reason this comment was not posted:
Confidence changes required:50%
The use ofmin-w-0andtruncateis appropriate for preventing overflow, but thetitleattribute should be used consistently for all truncated elements to provide full information on hover.
2. skyvern-frontend/src/routes/workflows/WorkflowRun.tsx:396
- Draft comment:
Ensure thetitleattribute is used consistently for all truncated elements to provide full information on hover. This is done correctly here, but check other similar elements. - Reason this comment was not posted:
Confidence changes required:50%
The use ofmin-w-0andtruncateis appropriate for preventing overflow, but thetitleattribute should be used consistently for all truncated elements to provide full information on hover.
Workflow ID: wflow_wT4kDzay5iiU8326
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Prevent text overflow in
WorkflowRun.tsxsidebar by addingmin-w-0andtruncateattributes.min-w-0to the sidebardivinWorkflowRun.tsxto prevent overflow.truncateandtitleattributes tospanelements displayingcurrentRunningTask.request.urlandcurrentRunningTask.created_atto handle text overflow.This description was created by
for ef118a5. It will automatically update as commits are pushed.