Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose workflow failure reason to api #1200

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

LawyZheng
Copy link
Collaborator

@LawyZheng LawyZheng commented Nov 15, 2024

Important

Adds failure_reason to WorkflowRunStatusResponse and updates build_workflow_run_status_response to include it.

  • Behavior:
    • Adds failure_reason field to WorkflowRunStatusResponse in workflow.py to expose workflow failure reasons.
    • Updates build_workflow_run_status_response in service.py to include failure_reason from workflow_run.
  • Models:
    • Adds failure_reason to WorkflowRunStatusResponse in workflow.py.

This description was created by Ellipsis for c937364. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to c937364 in 10 seconds

More details
  • Looked at 25 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern/forge/sdk/workflow/models/workflow.py:117
  • Draft comment:
    Ensure that failure_reason is properly set and validated in all instances where WorkflowRunStatusResponse is used. This includes checking for nullability and ensuring that the failure reason is meaningful and secure to expose.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The addition of failure_reason to the WorkflowRunStatusResponse model is consistent with the changes in the service layer where failure_reason is being passed. This ensures that the failure reason is exposed through the API as intended.

Workflow ID: wflow_di1CG5avgBzQKZRY


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@LawyZheng LawyZheng merged commit 54f793c into main Nov 15, 2024
2 checks passed
@LawyZheng LawyZheng deleted the lawy/expose-workflow-failure-to-api branch November 15, 2024 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant