update prompt to avoid taking actions on disabled element #1202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 57eee19 in 14 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/forge/prompts/skyvern/extract-action.j2:6
- Draft comment:
Consider rephrasing for clarity:
Each interactable element is tagged with an ID. Avoid taking actions on disabled elements when alternative actions are available.
- Reason this comment was not posted:
Confidence changes required:50%
The change in the prompt is clear and aligns with the intent to avoid actions on disabled elements when alternatives exist. However, the wording can be improved for clarity.
Workflow ID: wflow_fkN7qXVeMiUHIU3P
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on f8dbf46 in 7 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/forge/prompts/skyvern/extract-action.j2:6
- Draft comment:
The change improves clarity by correcting the grammar. No issues found. - Reason this comment was not posted:
Confidence changes required:0%
The change in the prompt is a minor grammatical correction, improving clarity without altering functionality.
Workflow ID: wflow_SI3nHQKN6ms1DcqW
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Update prompt in
extract-action.j2to avoid actions on disabled elements when alternatives exist.extract-action.j2to avoid actions on disabled elements when alternative actions are available.This description was created by
for f8dbf46. It will automatically update as commits are pushed.