handle navigation failure and fail a task in workflow run #1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Enhance `TaskBlock.execute()` to handle navigation failures by marking tasks as failed and logging exceptions before re-raising them. > > - **Behavior**: > - In `TaskBlock.execute()`, handle `FailedToNavigateToUrl` by updating task status to failed in the database and logging the failure reason before re-raising the exception. > - Handle general exceptions similarly by updating task status to failed and logging the exception. > - **Logging**: > - Add logging for exceptions in `TaskBlock.execute()` to provide context on task and workflow run IDs. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 82e641ed46e72ac0a29098e374d0b13060855132. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on bc3e2d4 in 9 seconds
More details
- Looked at
49lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/forge/sdk/workflow/models/block.py:318
- Draft comment:
Consider adding logging forFailedToNavigateToUrlexceptions to maintain consistency with general exception handling. - Reason this comment was not posted:
Confidence changes required:50%
The PR introduces exception handling forFailedToNavigateToUrland general exceptions inTaskBlock.execute(). However, the logging forFailedToNavigateToUrlis missing, which is inconsistent with the handling of general exceptions.
Workflow ID: wflow_WwWHh9ZgntyuxQKl
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to bc3e2d4 in 59 seconds
More details
- Looked at
49lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. skyvern/forge/sdk/workflow/models/block.py:318
- Draft comment:
Consider adding logging forFailedToNavigateToUrlexceptions to maintain consistency with general exception handling. - Reason this comment was not posted:
Confidence changes required:50%
The PR introduces exception handling forFailedToNavigateToUrland general exceptions in theTaskBlock.execute()method. However, the logging forFailedToNavigateToUrlis missing, which is inconsistent with the handling of general exceptions.
2. skyvern/forge/sdk/workflow/models/block.py:310
-
Draft comment:
This code duplicates existing exception handling logic inskyvern/forge/agent.py. Consider refactoring to use a common function for handlingFailedToNavigateToUrlexceptions. -
Exception handling for FailedToNavigateToUrl (agent.py)
-
Reason this comment was not posted:
Based on historical feedback, this comment is too similar to comments previously marked by users as bad.
Workflow ID: wflow_y9M8mlPILSS2ccQC
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
wintonzheng
deleted the
shu/handle_navigation_failure_and_fail_task_in_workflow
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Enhance
TaskBlock.execute()to handle navigation failures by marking tasks as failed and logging exceptions before re-raising them.TaskBlock.execute(), handleFailedToNavigateToUrlby updating task status to failed in the database and logging the failure reason before re-raising the exception.TaskBlock.execute()to provide context on task and workflow run IDs.This description was created by
for bc3e2d4. It will automatically update as commits are pushed.