Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce asyncpg db connector - the latest psycopg (3.2.3) has a bug somewhere which makes db query hangs forever #1208

Merged
merged 1 commit into from
Nov 17, 2024

Conversation

wintonzheng
Copy link
Contributor

@wintonzheng wintonzheng commented Nov 17, 2024

Important

Update psycopg version and add asyncpg to address database query hang issue.

  • Dependencies:
    • Update psycopg version from ^3.1.13 to 3.1.18 in pyproject.toml to fix a bug causing database query hangs.
    • Add asyncpg version ^0.30.0 to pyproject.toml for asynchronous database operations.

This description was created by Ellipsis for 6c4e83d. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 6c4e83d in 9 seconds

More details
  • Looked at 21 lines of code in 1 files
  • Skipped 1 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. pyproject.toml:29
  • Draft comment:
    The update to psycopg version 3.1.18 removes the extras for binary and pool. Ensure that these extras are not required for your application, as their removal might affect database connection pooling or binary data handling.
  • Reason this comment was not posted:
    Comment did not seem useful.

Workflow ID: wflow_4ORGEzpkWMqdiud0


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@wintonzheng wintonzheng changed the title The latest psycopg has a bug somewhere which makes db query hangs forever Introduce asyncpg db connector - the latest psycopg (3.2.3) has a bug somewhere which makes db query hangs forever Nov 17, 2024
@wintonzheng wintonzheng merged commit 3b156f6 into main Nov 17, 2024
2 checks passed
@wintonzheng wintonzheng deleted the shu/use_asyncpg branch November 17, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant