Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get psycopg-binary and psycopg-pool back #1209

Merged
merged 1 commit into from
Nov 17, 2024

Conversation

wintonzheng
Copy link
Contributor

@wintonzheng wintonzheng commented Nov 17, 2024

Important

Add binary and pool extras to psycopg dependency in pyproject.toml.

  • Dependencies:
    • Updated psycopg dependency in pyproject.toml to include binary and pool extras, enabling additional functionalities for binary data handling and connection pooling.

This description was created by Ellipsis for cd0f90e. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to cd0f90e in 8 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 1 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. pyproject.toml:29
  • Draft comment:
    Ensure that the 'binary' and 'pool' extras for psycopg are necessary for your project and compatible with other dependencies.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The change in the PR is to add extras 'binary' and 'pool' to the psycopg dependency. This is a valid change if the project requires these extras for its functionality. However, it's important to ensure that these extras are indeed needed and compatible with the rest of the project.

Workflow ID: wflow_XoEwYON49I1rAB2Y


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@wintonzheng wintonzheng merged commit 3119ab7 into main Nov 17, 2024
2 checks passed
@wintonzheng wintonzheng deleted the shu/get_psycopg_binary_and_pool_back branch November 17, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant