Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new example task gong.io #1210

Merged
merged 1 commit into from
Nov 18, 2024
Merged

add new example task gong.io #1210

merged 1 commit into from
Nov 18, 2024

Conversation

wintonzheng
Copy link
Contributor

@wintonzheng wintonzheng commented Nov 18, 2024

Important

Add extractIntegrationsFromGong task to example cases in PromptBox.tsx, sampleTaskData.ts, and types.ts.

  • Behavior:
    • Add extractIntegrationsFromGong task to PromptBox.tsx example cases.
    • Update getSample() in sampleTaskData.ts to return extractIntegrationsFromGong data.
  • Types:
    • Add extractIntegrationsFromGong to sampleCases in types.ts.

This description was created by Ellipsis for 04ad56e. It will automatically update as commits are pushed.

…src/'

<!-- ELLIPSIS_HIDDEN -->

> [!IMPORTANT]
> Add new example task `extractIntegrationsFromGong` to the frontend task creation flow.
>
>   - **Behavior**:
>     - Add new example task `extractIntegrationsFromGong` to `PromptBox.tsx` and `sampleTaskData.ts`.
>     - Update `getSample()` in `sampleTaskData.ts` to return `extractIntegrationsFromGong` data.
>   - **Types**:
>     - Add `extractIntegrationsFromGong` to `sampleCases` in `types.ts`.
>
> <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for ed1758d918488c5d2a61dc83cacafeb88cc64d6d. It will automatically update as commits are pushed.</sup>

<!-- ELLIPSIS_HIDDEN -->
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 04ad56e in 17 seconds

More details
  • Looked at 64 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 drafted comments based on config settings.
1. skyvern-frontend/src/routes/tasks/create/PromptBox.tsx:88
  • Draft comment:
    The addition of the 'extractIntegrationsFromGong' example case is consistent with the PR description and other changes.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The PR adds a new example task 'extractIntegrationsFromGong' to the list of example cases. This is consistent with the PR description and the changes in the other files.
2. skyvern-frontend/src/routes/tasks/data/sampleTaskData.ts:368
  • Draft comment:
    The addition of the 'extractIntegrationsFromGong' task is consistent with the PR description and other changes.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The PR adds a new task 'extractIntegrationsFromGong' to the sample task data. This is consistent with the PR description and other changes.
3. skyvern-frontend/src/routes/tasks/types.ts:15
  • Draft comment:
    The addition of 'extractIntegrationsFromGong' to the sampleCases array is consistent with the PR description and other changes.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The PR adds 'extractIntegrationsFromGong' to the sampleCases array, which is consistent with the PR description and other changes.

Workflow ID: wflow_b5WgY0QnIpsQL1LK


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 04ad56e in 33 seconds

More details
  • Looked at 64 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 drafted comments based on config settings.
1. skyvern-frontend/src/routes/tasks/create/PromptBox.tsx:91
  • Draft comment:
    The new task 'extractIntegrationsFromGong' is added correctly to the list of example cases.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The new task 'extractIntegrationsFromGong' is added correctly to the list of example cases in PromptBox.tsx.
2. skyvern-frontend/src/routes/tasks/data/sampleTaskData.ts:380
  • Draft comment:
    The new task 'extractIntegrationsFromGong' is added correctly to the sampleTaskData.ts file.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The new task 'extractIntegrationsFromGong' is added correctly to the sampleTaskData.ts file and is included in the getSample function.
3. skyvern-frontend/src/routes/tasks/types.ts:15
  • Draft comment:
    The new task 'extractIntegrationsFromGong' is added correctly to the sampleCases array.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The new task 'extractIntegrationsFromGong' is added correctly to the sampleCases array in types.ts.

Workflow ID: wflow_7TCsmC8WF5TOJwte


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@msalihaltun msalihaltun merged commit 5e253c8 into main Nov 18, 2024
2 checks passed
@msalihaltun msalihaltun deleted the salih/add-new-example-task branch November 18, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants