Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable download block #1212

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Disable download block #1212

merged 1 commit into from
Nov 18, 2024

Conversation

wintonzheng
Copy link
Contributor

@wintonzheng wintonzheng commented Nov 18, 2024

Important

Disables the "Download Block" in WorkflowNodeLibraryPanel.tsx by commenting out its entry in nodeLibraryItems.

  • Behavior:
    • Disables the "Download Block" in WorkflowNodeLibraryPanel.tsx by commenting out its entry in nodeLibraryItems.
    • The "Download Block" was intended to download files from S3.

This description was created by Ellipsis for 1214759. It will automatically update as commits are pushed.

…src/'

<!-- ELLIPSIS_HIDDEN -->

> [!IMPORTANT]
> Disable "Download Block" in `WorkflowNodeLibraryPanel.tsx` by commenting out its entry.
>
>   - **Behavior**:
>     - Disables the "Download Block" in `WorkflowNodeLibraryPanel.tsx` by commenting out its entry in `nodeLibraryItems`.
>     - The "Download Block" was intended to download files from S3.
>
> <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for b9f360d7a49abd79e244256b1a2189ec8ced8f5a. It will automatically update as commits are pushed.</sup>

<!-- ELLIPSIS_HIDDEN -->
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 1214759 in 8 seconds

More details
  • Looked at 32 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/panels/WorkflowNodeLibraryPanel.tsx:5
  • Draft comment:
    Remove the unused DownloadIcon import since the "Download Block" is commented out.
  EnvelopeClosedIcon,
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The import of DownloadIcon is no longer needed since the "Download Block" is commented out.

Workflow ID: wflow_4XukPapC0bAdQPcz


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 1214759 in 7 seconds

More details
  • Looked at 32 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/panels/WorkflowNodeLibraryPanel.tsx:5
  • Draft comment:
    The DownloadIcon import is unused and can be removed to clean up the code.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The import of DownloadIcon is no longer needed since the related code is commented out.

Workflow ID: wflow_7m8gQpvHgzlN3GXs


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@msalihaltun msalihaltun merged commit 3d6c1dd into main Nov 18, 2024
2 checks passed
@msalihaltun msalihaltun deleted the salih/disable-download-block branch November 18, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants