Remove Proxy Location None from Proxy selector #1216
Conversation
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Remove 'None' option from proxy location selector in `ProxySelector.tsx`. > > - **Behavior**: > - Removed `SelectItem` with value `ProxyLocation.None` from `ProxySelector` in `ProxySelector.tsx`. > - Users can no longer select 'None' as a proxy location. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 8bb7037c2c19c4d587ab0fb3b4f5bea84a150496. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on ffbc5e7 in 11 seconds
More details
- Looked at
12lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_e2XdxEI5KuSLJZrd
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to ffbc5e7 in 43 seconds
More details
- Looked at
12lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_hguBXNeBP0Zxd7pg
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -32,7 +32,6 @@ function ProxySelector({ value, onChange }: Props) { | |||
| <SelectItem value={ProxyLocation.ResidentialJP}> | |||
There was a problem hiding this comment.
Consider updating the onChange function type to handle null values since value can be null. This ensures type safety and prevents potential runtime errors.
| <SelectItem value={ProxyLocation.ResidentialJP}> | |
| onChange: (value: ProxyLocation | null) => void; |
Important
Remove 'None' option from proxy location selector in
ProxySelector.tsx, disallowing users from selecting it.SelectItemwith valueProxyLocation.NonefromProxySelectorinProxySelector.tsx.This description was created by
for ffbc5e7. It will automatically update as commits are pushed.