Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of failed to summarize failure reason #1218

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

wintonzheng
Copy link
Contributor

@wintonzheng wintonzheng commented Nov 19, 2024

Important

Improve logging and error handling in summary_failure_reason_for_max_steps() in agent.py.

  • Logging:
    • Change log level from exception to warning in summary_failure_reason_for_max_steps() in agent.py.
    • Add task_id and step_id to log message for better traceability.
  • Error Handling:
    • Add fallback return value in summary_failure_reason_for_max_steps() to return last step's action results if an exception occurs.

This description was created by Ellipsis for 9e5c56f. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 9e5c56f in 13 seconds

More details
  • Looked at 31 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern/forge/agent.py:1745
  • Draft comment:
    Typo in log message: 'summary' should be 'summarize'.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The log message in the exception block should use 'summarize' instead of 'summary' to match the function name and context.

Workflow ID: wflow_3R8lS4uEpsJ2uYCl


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@wintonzheng wintonzheng merged commit 5477612 into main Nov 19, 2024
2 checks passed
@wintonzheng wintonzheng deleted the shu/better_failure_summary branch November 19, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant